Fix flaky parity whisper test

ethereum · Sep 12, 2019 · 808fd95 · 808fd95
1 parent 677cc87
commit 808fd95
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/newsfragments/1147.bugfix.rst b/newsfragments/1147.bugfix.rst
@@ -0,0 +1 @@
+Fix flaky parity integration test in the whisper module
diff --git a/web3/_utils/module_testing/shh_module.py b/web3/_utils/module_testing/shh_module.py
@@ -1,3 +1,4 @@
+import pytest
 import time
 
 from eth_utils import (
@@ -312,6 +313,10 @@ def test_shh_async_filter(self, web3):
 
         watcher.stop()
 
+    # Sometimes the post fails because PoW is too low.
+    # We don't care if an error or a True response comes back,
+    # we only care that we're interfacing correctly with Parity
+    @pytest.mark.xfail(strict=False, raises=ValueError)
     def test_shh_remove_filter(self, web3):
         receiver = web3.parity.shh.newKeyPair()
         receiver_pub = web3.parity.shh.getPublicKey(receiver)
@@ -375,6 +380,11 @@ def test_shh_symmetric_key_pair(self, web3):
     #
     # shh_post
     #
+
+    # Sometimes the post fails because PoW is too low.
+    # We don't care if an error or a True response comes back,
+    # we only care that we're interfacing correctly with Parity
+    @pytest.mark.xfail(strict=False, raises=ValueError)
     def test_shh_post(self, web3):
         sender = web3.parity.shh.newKeyPair()
         assert web3.parity.shh.post({
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix flaky parity integration test in the whisper module