test: add a rpc test confirming that we support batched requests #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
requested review from
carver,
njgheorghita,
KolbyML,
ogenev and
morph-dev
KolbyML
reviewed
Jan 16, 2025
Comment on lines
99
to
108
| let client_version_fut = batch | ||
| .add_call::<(), serde_json::Value>("web3_clientVersion", &()) | ||
| .unwrap(); | ||
| let node_info_fut = batch | ||
| .add_call::<(), serde_json::Value>("discv5_nodeInfo", &()) | ||
| .unwrap(); | ||
|
|
||
| batch.send().await.unwrap(); | ||
| client_version_fut.await.unwrap(); | ||
| node_info_fut.await.unwrap(); |
There was a problem hiding this comment.
what is fut? I think it is fine if we just write future there, makes it more readable for people
There was a problem hiding this comment.
Sweet, just made the change
KolbyML
approved these changes
Jan 17, 2025
PR looks good. Thank you for your contribution 🥳
KolbyML
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Adds test case described in #1571 which adds a test case ensuring batch calls are supported.
How was it fixed?
used allow http rpcclient to batch call trin node
To-Do