refactor: perform local db content lookup at OverlayService level

[njgheorghita]

What was wrong?

Fixes #1329
This feature is needed to more efficiently perform beacon sync inside hive tests.

How was it fixed?

• Perform local store content lookup at OverlayService level rather than at JsonRpc level.

To-Do

• Clean up commit history and use conventional commits.

[KolbyML]

Suggested change

	// Lookup content locally before querying the network.
	if let Ok(Some(content)) = self.store.read().get(&target) {
	let local_enr = self.local_enr();
	let mut query_trace = QueryTrace::new(&local_enr, target.content_id().into());
	query_trace.node_responded_with_content(&local_enr);
	query_trace.content_validated(local_enr.into());
	if let Some(callback) = callback {
	let _ = callback.send(Ok((
	RawContentValue::from(content),
	false,
	Some(query_trace),
	)));
	return;
	} else {
	warn!("Local content found but no callback to return it to overlay protocol, continuing with network query & ignoring local content.");
	}
	}
	// Lookup content locally before querying the network.
	if let Ok(Some(content)) = self.store.read().get(&target) {
	let local_enr = self.local_enr();
	let mut query_trace = QueryTrace::new(&local_enr, target.content_id().into());
	query_trace.node_responded_with_content(&local_enr);
	query_trace.content_validated(local_enr.into());
	if let Some(callback) = callback {
	let _ = callback.send(Ok((
	RawContentValue::from(content),
	false,
	Some(query_trace),
	)));
	return;
	} else {
	warn!("Local content found but no callback to return it to overlay protocol, continuing with network query & ignoring local content.");
	}
	}

I think we should remove the Option on the callback, the option is only used for testing, which tastes weird, also we should remove this warn! and check if there is a channel, before checking local storage as this is an expensive operation.

But as I said before we should just remove the option, I don't think we should have special arguments just for writing unit tests.

It doesn't make sense to do a storage lookup, if we aren't going to use it.

[KolbyML]

Suggested change

	callback: Option<oneshot::Sender<RecursiveFindContentResult>>,
	callback: oneshot::Sender<RecursiveFindContentResult>,

I don't think this should be an option

[KolbyML]

this PR looks very good