-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement new trie_walker which can iterate full+partial tries #1567
Merged
KolbyML
merged 4 commits into
ethereum:master
from
KolbyML:replace-old-trie-walker-implementation
Oct 31, 2024
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
use std::sync::Arc; | ||
|
||
use anyhow::anyhow; | ||
use eth_trie::DB; | ||
use hashbrown::HashMap; | ||
use parking_lot::Mutex; | ||
use revm_primitives::B256; | ||
use thiserror::Error; | ||
|
||
#[derive(Debug, Error)] | ||
pub enum ReadOnlyMemoryDBError { | ||
morph-dev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
#[error("read only memory db error {0}")] | ||
ANYHOW(#[from] anyhow::Error), | ||
} | ||
|
||
#[derive(Debug)] | ||
pub struct ReadOnlyMemoryDB { | ||
storage: Arc<Mutex<HashMap<B256, Vec<u8>>>>, | ||
morph-dev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
impl ReadOnlyMemoryDB { | ||
pub fn new(storage: HashMap<B256, Vec<u8>>) -> Self { | ||
ReadOnlyMemoryDB { | ||
storage: Arc::new(Mutex::new(storage)), | ||
} | ||
} | ||
} | ||
|
||
impl DB for ReadOnlyMemoryDB { | ||
type Error = ReadOnlyMemoryDBError; | ||
|
||
fn get(&self, key: &[u8]) -> Result<Option<Vec<u8>>, Self::Error> { | ||
Ok(self.storage.lock().get(key).cloned()) | ||
} | ||
|
||
fn insert(&self, _key: &[u8], _value: Vec<u8>) -> Result<(), Self::Error> { | ||
Err(anyhow!("Cannot insert into read only memory db").into()) | ||
} | ||
|
||
fn remove(&self, _key: &[u8]) -> Result<(), Self::Error> { | ||
Err(anyhow!("Cannot remove from read only memory db").into()) | ||
} | ||
|
||
fn flush(&self) -> Result<(), Self::Error> { | ||
Err(anyhow!("Cannot flush read only memory db").into()) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
pub mod memory_db; | ||
pub mod trie_walker; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of partially implementing
eth_trie::DB
trait, how about we define out own trait. Something like this:Then we can implement it for whatever structure we want
And then we would have something like this in the other file:
What do you think?
If you decide to go this path, ignore the rest of the comments in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can even add some custom logic if needed. Not sure how useful it is, but we can do something like this: