Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove/ignore tests which download from a remote server #1547

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

KolbyML
Copy link
Member

@KolbyML KolbyML commented Oct 23, 2024

What was wrong?

We had tests which would fail due to missing data on a website, some tests still fail too due to this, but we want those tests so I set them to ignore

How was it fixed?

removing the tests or ignore them. Trin Execution will still exit on start with the errors if any era files are missing so we are good

@KolbyML KolbyML changed the title chore: remove era1/era download tests chore: remove/ignore tests which download from a remote server Oct 23, 2024
Copy link
Collaborator

@carver carver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sounds good. I'll close #1546

I do think we still want to have the error include which index is missing, like this commit: 531b0e1

@KolbyML
Copy link
Member Author

KolbyML commented Oct 24, 2024

Yeah, sounds good. I'll close #1546

I do think we still want to have the error include which index is missing, like this commit: 531b0e1

Sounds good I made the error look like Epoch indices are not starting from zero or not consecutive: missing epochs [50, 500] as it looks nice

@KolbyML KolbyML merged commit 96a2152 into ethereum:master Oct 24, 2024
9 checks passed
@KolbyML KolbyML deleted the add-panic branch October 24, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants