fix: revert changed const in peertest utils and fix light client update validation test #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogenev
changed the title
carver
reviewed
Oct 10, 2024
Comment on lines
+444
to
+445
| // Expect error because the content key finalized slot is greaten than the light client | ||
| // update finalized slot |
There was a problem hiding this comment.
Suggested change
| // Expect error because the content key finalized slot is greaten than the light client | |
| // update finalized slot | |
| // Expect error because the content key finalized slot is greater than the light client | |
| // update finalized slot |
But I don't think it's worth kicking off the tests again, since I'm waiting to run the deploy until this PR gets into master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
How was it fixed?
To-Do