test: add test for default utp concurrency limit #1514
Conversation
njgheorghita
force-pushed
the
concurrency
branch
2 times, most recently
from
70a070b to
596a813
Compare
njgheorghita
force-pushed
the
concurrency
branch
from
596a813 to
b820475
Compare
| @@ -29,7 +29,7 @@ where | |||
| Fut: Future<Output = Result<O>>, | |||
| { | |||
| // If content is absent an error will be returned. | |||
| for counter in 0..60 { | |||
There was a problem hiding this comment.
I think this made some tests flaky, at least when running on circleci. The test that is frequently failing (with "Retried too many times" panic) is peertest_history_offer_propagates_gossip_multiple_large_content_values.
Test passes fine when I run it locally.
There was a problem hiding this comment.
Hmmm, thanks for the heads up. I'll look into it
There was a problem hiding this comment.
Well, I made this change since it's a real pain to wait for a minute if the test fails locally. I assumed (incorrectly) that this change wouldn't affect any of our tests since the wait time is fairly long. But, I have no problem with you reverting the 10 -> 60 in #1515 . It's fairly simple to make this change when testing locally if it becomes a pain in the future
What was wrong?
Added a test to make sure that trin will always manage at least the default # of concurrent utp txs. The test/constant can also easily be increased to test trin's real tx capacity (currently somewhere around 100 from what I've seen, but still working to see if this can be improved)
How was it fixed?
Added the test
To-Do