refactor(trin-execution): state import/export don't need TrinExecution

[morph-dev]

What was wrong?

The import/export state in trin-execution don't need TrinExecution. They only need EvmDb and ExecutionPosition.

No tests that test import/export end to end.

How was it fixed?

Refactor how Importer/Exporter are initialized.

Also added test that:

• executes fist 1000 blocks
• exports state to era2 file
• imports state from era2 file (into new directory)
• executes another 1000 blocks

To-Do

• Clean up commit history and use conventional commits.

[KolbyML]

Most of the PR looks good, but I don't think the subcommand's should have a param data_dir, the param from TrinExecutionConfig should be used.

./trin --data-dir="/" import-state --data-dir="/hi"
^ this is a valid commandline in this PR

I think this is very misleading to the user.

./trin --data-dir="/" import-state
^ I think we should have this. As the data-directory for Trin-Execution shouldn't be an param of a subcommand, it should be a param of Trin-Execution itself

[KolbyML]

Also I think the first commit is a refactor not a feat as no functionality is changed other then the issue I mentioned above

[KolbyML]

Also to note Data dir import export is already supported before this PR using

./trin --data-dir="/" import-state This matches how other execution clients like go-ethereum do it as well for there era1 import/export

[morph-dev]

You are right. I was trying:

./target/release/trin-execution export-state --data-dir="/my_dir" --path-to-era2="/era_dir"

and that didn't work. And I interpreted the error that I was getting as that none of the other cli arguments are available if subcommand is selected.
But you are right. It works if you specify the argument before subcommand.

If I knew this, I probably wouldn't even do this PR. But I think it's nice improvement (main is a bit cleaner) and we have a test.

[KolbyML]

You are right. I was trying:

./target/release/trin-execution export-state --data-dir="/my_dir" --path-to-era2="/era_dir"

and that didn't work. And I interpreted the error that I was getting as that none of the other cli arguments are available if subcommand is selected. But you are right. It works if you specify the argument before subcommand.

If I knew this, I probably wouldn't even do this PR. But I think it's nice improvement (main is a bit cleaner) and we have a test.

Yeah, I guess we should add a few examples in the readme to document this. You can do this in this PR, or I can make a PR for this after this is merged, or something doesn't matter. But it would be nice to prevent confusion surrounding this in the future

[KolbyML]

everything looks good. Don't forget to

    // Initialize prometheus metrics
    if let Some(addr) = trin_execution_config.enable_metrics_with_url {
        prometheus_exporter::start(addr)?;
    }

To before the sub command code so logs work (ideally it is as high as it can go).

Other then the the PR looks good

[morph-dev]

Yeah, I guess we should add a few examples in the readme to document this. You can do this in this PR, or I can make a PR for this after this is merged, or something doesn't matter. But it would be nice to prevent confusion surrounding this in the future

Unless I missed it, I don't think we have documentation for import/export at all. I would leave that for another PR.