feat(beacon): validate HistoricalSummariesWithProof if finalized state root is available
#1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
approved these changes
Sep 26, 2024
| latest_finalized_root, | ||
| ) | ||
| .await?; | ||
| if let Ok(latest_finalized_root) = latest_finalized_root { |
There was a problem hiding this comment.
Is it worth logging a warn! here in the case that the latest_finalized_root is not available?
There was a problem hiding this comment.
Added a debug! log because this is expected to happen if the light client is not synced.
…ate root is available
ogenev
force-pushed
the
historical-summaries-validation
branch
from
a721107 to
9bf7d3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
When the beacon light client is not synced, we can't process a
HistoricalSummariesWithProofcontent to aFindContentrequest.How was it fixed?
Validate
HistoricalSummariesWithProofagainst the state root if the light client finalized root is available.To-Do