fix(portal-bridge): re-initialize census if no peers are available #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
census-re-init
branch
from
00d0f0b to
cffbfd1
Compare
njgheorghita
force-pushed
the
census-re-init
branch
3 times, most recently
from
166d327 to
aea1b93
Compare
morph-dev
approved these changes
Sep 24, 2024
portal-bridge/src/census.rs
Outdated
| @@ -52,11 +59,15 @@ impl Census { | |||
| } | |||
|
|
|||
| impl Census { | |||
| pub async fn init(&mut self) { | |||
| pub async fn init(&mut self) -> anyhow::Result<()> { | |||
There was a problem hiding this comment.
nit: Should this also be Result<(), CensusError>?
portal-bridge/src/main.rs
Outdated
| @@ -56,7 +56,9 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
| let (census_tx, census_rx) = mpsc::unbounded_channel(); | |||
| let mut census = Census::new(portal_client.clone(), census_rx); | |||
| // initialize the census to acquire critical threshold view of network before gossiping | |||
| census.init().await; | |||
| if census.init().await.is_err() { | |||
There was a problem hiding this comment.
nit: In my opinion, main can just return anyhow::Result<()> and you can use anyhow!(..) here. Or just use census.init().await?; and propagate error.
njgheorghita
force-pushed
the
census-re-init
branch
from
aea1b93 to
ac09230
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
One of the state bridges is stuck, and only displays a large amount of
No known peers in state census, unable to offer.errors in the logs.How was it fixed?
I had trouble re-producing this locally, but I think these changes will help. There are 2 cases where we might want to re-initialize the census
To-Do