Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(beacon): load trusted block root from database if not provided via CLI #1427

Merged
merged 1 commit into from
Sep 9, 2024
Merged

feat(beacon): load trusted block root from database if not provided via CLI #1427

merged 1 commit into from
Sep 9, 2024

Conversation

ogenev
Copy link
Member

@ogenev ogenev commented Sep 6, 2024 •
edited
Loading

What was wrong?

Fixes #1405.

How was it fixed?

  • add logic to check for a recent trusted block root if not provided via CLI
  • update trusted_block_root argument to B256.
  • fix lookup_lc_bootstrap_block_root method

To-Do

@ogenev ogenev force-pushed the trusted-block-root branch from caafad9 to ae13726 Compare September 6, 2024 14:52
@ogenev ogenev self-assigned this Sep 6, 2024
@ogenev ogenev added the beacon network Issue related to portal beacon network label Sep 6, 2024
@ogenev ogenev marked this pull request as ready for review September 6, 2024 15:03
KolbyML
KolbyML approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ogenev ogenev merged commit d83cbe7 into ethereum:master Sep 9, 2024
9 checks passed
@ogenev ogenev deleted the trusted-block-root branch September 9, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KolbyML KolbyML KolbyML approved these changes

@njgheorghita njgheorghita Awaiting requested review from njgheorghita

@morph-dev morph-dev Awaiting requested review from morph-dev

Assignees

@ogenev ogenev

Labels
beacon network Issue related to portal beacon network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

beacon-network: Check for a recent bootstrap in db if trusted-block-root argument is not provided
2 participants
@ogenev @KolbyML