feat: implement eth_getBalance, eth_getCode and eth_getStorageAt #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The
eth_getBalance,eth_getCodeandeth_getStorageAtweren't implemented.How was it fixed?
Implemented them by fetching data from history (block header) and state network (traversing tries).
I also tested it locally by running trin myself and getting data from block 51208 (I knew that block was gossiped already).
Future improvements
All these requests support passing block as one of:
Currently we only support block hash, but in the future we want to support block number as well (e.g. when we have block index network).
I think in the future we can support tags as well, but I would say that's the lowest of priorities at the moment.
To-Do