fix: temporarily skip caching non-portal nodes in discovery #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
node-addr-cache
branch
from
1adec0b to
9c6f7c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Temporary solution to validate the theory that eth2 nodes are overflowing the
node_addr_cacheon mainnet. Once the theory is validated/invalidated, this solution will be replaced with a more sustainable solution, since this solution will result in the exact same issue once the total number of portal nodes on the network exceeds current cache size.How was it fixed?
"c"enr key - indicating that they are participating in the portal networkTo-Do