feat: create json-rpc mock builder #1378
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
There is no easy way to mock our json-rpc request/responses which makes unit test of certain parts of the codebase very challenging.
How was it fixed?
Created json-rpc mock builder, that is very customization.
See example of the real PR use case here
That case can be simplified even further (since it only cares about one response) in the following way:
For more complex logic, one can do something like this:
To-Do