fix(e2store): era missing a beacon block off by 1 error #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morph-dev
approved these changes
Aug 13, 2024
e2store/src/era.rs
Outdated
| @@ -50,7 +50,7 @@ impl Era { | |||
|
|
|||
| // Iterate over the block entries. Skip the first and last 3 entries. | |||
| let mut next_slot = slot_index_block.slot_index.starting_slot; | |||
| for idx in 1..entries_length - 4 { | |||
| for idx in 1..entries_length - 3 { | |||
| let entry: Entry = file.entries[idx].clone(); | |||
There was a problem hiding this comment.
nit: While you are at it, this cloning seems completely unnecessary (we can just pass &file.entries[idx] below).
KolbyML
force-pushed
the
fix-bug-in-era-implementation
branch
from
a1483c2 to
716f281
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
When I was testing reading beacon blocks from era files when I compared the result of era 600 and era 601 their execution numbers didn't line up by 1 block, when I fixed this they lined up and I could linearly scan blocks from era files
I tested this for a few other sequential era files and the issues remained the same
How was it fixed?
change the 4 to a 3