Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add various gossip propagation scenarios to peertest #1345

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

njgheorghita
Copy link
Collaborator

@njgheorghita njgheorghita commented Jul 24, 2024

What was wrong?

Added some tests while debugging #1341 - turns out the bug was in the utp library, but it seems to me like these are still useful scenarios to include inside peertest.

How was it fixed?

  • added scenarios for various gossip propagation tests
  • updated to latest utp version

To-Do

@njgheorghita njgheorghita changed the title dirty fix: broken gossip propagation for large content values Jul 24, 2024
@njgheorghita njgheorghita mentioned this pull request Jul 26, 2024
1 task
@njgheorghita njgheorghita force-pushed the propagate-two branch 9 times, most recently from a797445 to ec5e286 Compare August 2, 2024 16:21
@njgheorghita njgheorghita changed the title fix: broken gossip propagation for large content values test: add peertests various gossip propagation scenarios Aug 2, 2024
@njgheorghita njgheorghita changed the title test: add peertests various gossip propagation scenarios test: add various gossip propagation scenarios to peertest Aug 2, 2024
@njgheorghita njgheorghita marked this pull request as ready for review August 2, 2024 16:53
Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@njgheorghita njgheorghita merged commit b07e474 into ethereum:master Aug 2, 2024
8 checks passed
@njgheorghita njgheorghita deleted the propagate-two branch August 2, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants