feat(state): implement jsonrpc for the state network #1175
Conversation
| find_content(network, enr, content_key).await | ||
| } | ||
| StateEndpoint::RecursiveFindContent(content_key) => { | ||
| recursive_find_content(network, content_key, /* is_trace= */ false).await |
There was a problem hiding this comment.
Nice, didn't know we could inline comments this way 💡
There was a problem hiding this comment.
As I've mentioned in a previous pr, I don't love it. But, I guess in this case especially I see the usefulness. And creating a let is_trace=false; variable does seem overkill. So, maybe I'll have to change my mind about this
There was a problem hiding this comment.
They might look weird at first, but they grow on you.
They shouldn't be overused, but they have their use cases.
| find_content(network, enr, content_key).await | ||
| } | ||
| StateEndpoint::RecursiveFindContent(content_key) => { | ||
| recursive_find_content(network, content_key, /* is_trace= */ false).await |
There was a problem hiding this comment.
As I've mentioned in a previous pr, I don't love it. But, I guess in this case especially I see the usefulness. And creating a let is_trace=false; variable does seem overkill. So, maybe I'll have to change my mind about this
morph-dev
force-pushed
the
state_jsonrpc
branch
from
527bac2 to
85af987
Compare
morph-dev
force-pushed
the
state_jsonrpc
branch
from
85af987 to
2ea192a
Compare
What was wrong?
A lot of json_rpc methods weren't implemented for the state network.
How was it fixed?
Implemented missing methods.
Most of them were implemented in a similar/same way as the history network.
NOTE: Currently, none of these methods would work because storage for the state network is not implemented. However, I do have some version of the storage implemented in the local branch and methods that I tested work fine.
To-Do