feat(bridge): history latest log error if provider isn't giving new blocks #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
force-pushed
the
print-an-error-if-provider-doesn't-give-us-the-stuff-we-want
branch
from
734935e to
55c385a
Compare
ogenev
approved these changes
Feb 8, 2024
portal-bridge/src/bridge/history.rs
Outdated
| // If a provider returns the same block number and doesn't time out over and over. | ||
| // this indictates the provider is no longer in sync with the chain so we want to long an | ||
| // error | ||
| let mut seen_old_latest_block_index = 0; |
There was a problem hiding this comment.
I think renaming this to counter is more clear:
Suggested change
| let mut seen_old_latest_block_index = 0; | |
| let mut old_latest_block_counter = 0; |
There was a problem hiding this comment.
maybe last_seen_block_counter?
portal-bridge/src/bridge/history.rs
Outdated
| @@ -128,6 +134,12 @@ impl HistoryBridge { | |||
| } | |||
| block_index = gossip_range.end; | |||
| } | |||
| // Ethereum mainnet creates a new block every 15 seconds, if we don't get 1 new block in | |||
There was a problem hiding this comment.
Could you paraphrase this comment, it is not very clear to me?
portal-bridge/src/bridge/history.rs
Outdated
| // the time period 4 new blocks should exist report an error something is | ||
| // wrong with the EL provider | ||
| if seen_old_latest_block_index > 60 / LATEST_BLOCK_POLL_RATE { | ||
| tracing::error!("History Latest: Haven't receieved a new block in over 60 seconds EL provider could be out of sync"); |
There was a problem hiding this comment.
nitpick:
Suggested change
| tracing::error!("History Latest: Haven't receieved a new block in over 60 seconds EL provider could be out of sync"); | |
| tracing::error!("History Latest: Haven't receieved a new block in over 60 seconds. EL provider could be out of sync."); |
There was a problem hiding this comment.
receieved -> received
njgheorghita
approved these changes
Feb 8, 2024
portal-bridge/src/bridge/history.rs
Outdated
| // If a provider returns the same block number and doesn't time out over and over. | ||
| // this indictates the provider is no longer in sync with the chain so we want to long an | ||
| // error | ||
| let mut seen_old_latest_block_index = 0; |
There was a problem hiding this comment.
maybe last_seen_block_counter?
portal-bridge/src/bridge/history.rs
Outdated
| // the time period 4 new blocks should exist report an error something is | ||
| // wrong with the EL provider | ||
| if seen_old_latest_block_index > 60 / LATEST_BLOCK_POLL_RATE { | ||
| tracing::error!("History Latest: Haven't receieved a new block in over 60 seconds EL provider could be out of sync"); |
There was a problem hiding this comment.
receieved -> received
portal-bridge/src/bridge/history.rs
Outdated
| @@ -102,6 +102,10 @@ impl HistoryBridge { | |||
| let mut block_index = self.execution_api.get_latest_block_number().await.expect( | |||
| "Error launching bridge in latest mode. Unable to get latest block from provider.", | |||
| ); | |||
| // If a provider returns the same block number and doesn't time out over and over. | |||
| // this indictates the provider is no longer in sync with the chain so we want to long an | |||
KolbyML
deleted the
print-an-error-if-provider-doesn't-give-us-the-stuff-we-want
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Currently if a provider is working, but falls out of sync with the chain we report 0 logs that the history bridge is alive or something is wrong or not. If this case happens it is a clear case the EL provider is out of sync so we should inform the user regardless.
How was it fixed?
Add a counter which prints an error if the provider doesn't give us a new block for over a minute.
This error could go off if the provider down as well either way we want to ring some bells something is wrong with the provider.