feat(bridge): add http request timeout to prevent requests over 6 minutes #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
approved these changes
Feb 8, 2024
portal-bridge/src/constants.rs
Outdated
| @@ -14,3 +16,7 @@ pub const BEACON_GENESIS_TIME: u64 = 1606824023; | |||
|
|
|||
| pub const PROVIDER_DAILY_REQUEST_LIMIT: f64 = 1_000_000.0; | |||
| pub const SECONDS_IN_A_DAY: f64 = 86400.0; | |||
|
|
|||
| // This is a very conservative timeout if a provider takes longer then even 1 second it is probably | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Yesterday when testing the bridge we found that a surf http request took 6 minutes to respond. We assume this is becase the provider took forever to respond. Either way we don't want to wait 6 minutes + to timeout if a provider can't respond in a responsible about of time we should give up and log it, so we aren't confused why we aren't seeing logs.
How was it fixed?
by setting a 20 second timeout in surf.
I choose 20 seconds to be conservative. I don't believe any provider request should take over 1s and if that does happens the provider is overloaded.