refactor(e2store): refactor e2store utils #1145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Converting bytes to rust types and rust types to bytes is common as serializing and deserializing.
Even if we don't use the serde framework for deserializing/serializing Era files (at this stage), I think it is nice if we don't deviate much from the common concepts.
How was it fixed?
File
toE2storeFIle
read
todeserialize
because this is what we are trying to do here: deserialize from a byte slice into a type.encode
toserialize
.