feat(state_network): implement enr and node_id endpoints for state network #1143
Conversation
| @@ -14,42 +14,42 @@ pub enum Discv5Endpoint { | |||
| /// State network JSON-RPC endpoints. Start with "portal_state" prefix | |||
| #[derive(Debug, PartialEq, Eq, Clone)] | |||
| pub enum StateEndpoint { | |||
There was a problem hiding this comment.
I reordered these so they are grouped by similar logic: enr/node related, content related
There was a problem hiding this comment.
@morph-dev Any thoughts on adding some tests to ethportal-peertest? Seems like simply copying some history endpoints in basic.rs is a good place to start. There's certainly some opportunity for refactoring, since I don't believe ethportal-peertest was updated throughout the beacon network implementation. However, I don't feel too strongly about refactoring ethportal-peertest but these seem like endpoints that should be tested. I'm also happy if you want to do it in a following pr
I think we definitely need to revisit and refactor |
|
I added some tests to More refactoring would be needed for future tests. And probably with a different approach (because content key/value types are different). |
What was wrong?
State network doesn't have any endpoint implemented.
How was it fixed?
I added implementation for the enr and node_id related queries.
Next steps are:
StateStorage(at least minimal support for now)To-Do