feat(state network): improve StateContentKey tests #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogenev
reviewed
Feb 5, 2024
| #[case::account_trie_node_key("account_trie_node_key.yaml")] | ||
| #[case::contract_storage_trie_node_key("contract_storage_trie_node_key.yaml")] | ||
| #[case::contract_bytecode_key("contract_bytecode_key.yaml")] | ||
| fn encode_decode(#[case] filename: &str) -> Result<()> { |
There was a problem hiding this comment.
I don't think that we need to return Result here and in other tests., because we are not doing anything with the error. In tests we usually want to panic or return ().
There was a problem hiding this comment.
I personally like to return Result in tests because I can use ? operator instead of .unwrap(), which in my mind makes code cleaner (returning Err makes the code fail).
I also don't think it's something that is generally considered bad practice. See:
Rust Book: https://doc.rust-lang.org/book/ch11-01-writing-tests.html#using-resultt-e-in-tests
Rust by Example: https://doc.rust-lang.org/rust-by-example/testing/unit_testing.html#tests-and-
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The StateContentKey tests weren't using test vectors from
portal-spec-testsand they weren't testing serialization.How was it fixed?
I rewrote the tests and added new one.
To-Do