Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial utils for reading/writing e2s files #1122

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

njgheorghita
Copy link
Collaborator

@njgheorghita njgheorghita commented Jan 29, 2024

What was wrong?

In portal-bridge we'll soon need the ability to read/write era1 files. These are the initial set of utils for reading/writing e2s files, which are the standard format that era1 files are based on

How was it fixed?

  • Implemented basic encode/decode functionality for e2s files
  • Added standard test vectors

To-Do

Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: nothing stands out as wrong. I want to get this in so we (nick/ogy) can start iterating on it

@njgheorghita njgheorghita merged commit 76c5434 into ethereum:master Jan 29, 2024
8 checks passed
@njgheorghita njgheorghita deleted the e2s branch January 29, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants