fix: update receipts type to work with pre-byzantium receipts #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
pre-byzantium-receipts
branch
from
b3163bf to
894de6e
Compare
KolbyML
approved these changes
Jan 25, 2024
very cool of RyanSchneider helping us fix this by letting us know they do serve roots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Pre-byzantium receipts were actually broken. Since pre-byzantium receipts have a different name for the
"root"field, as opposed to"status"for post-byzantium, we need a way to decode either type.How was it fixed?
"outcome"fieldTo-Do