Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: report correct storage metrics for beacon and history #1105

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Jan 20, 2024

resolve: #1097

added storage calculation as described in the issue

@qiweiii qiweiii changed the title feat: report correct storage metrics for beacon feat: report correct storage metrics for beacon and history Jan 20, 2024
@qiweiii qiweiii marked this pull request as ready for review January 21, 2024 03:20
Copy link
Member

@ogenev ogenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 .

trin-history/src/storage.rs Outdated Show resolved Hide resolved
trin-beacon/src/storage.rs Show resolved Hide resolved
trin-beacon/src/storage.rs Outdated Show resolved Hide resolved
@qiweiii qiweiii requested a review from ogenev January 24, 2024 01:54
Copy link
Member

@ogenev ogenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ogenev ogenev merged commit 4c989aa into ethereum:master Jan 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report correct storage metrics for beacon and history network
2 participants