Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-compile Trin on a new release #1012

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Cross-compile Trin on a new release #1012

merged 1 commit into from
Feb 1, 2024

Conversation

ogenev
Copy link
Member

@ogenev ogenev commented Oct 30, 2023 •
edited
Loading

What was wrong?

We integrated a GitHub action to release pre-compiled binaries on git push <tag> but we missed an updated Make file with the required commands.

How was it fixed?

  1. Updated the Make file with commands to compile for the following architectures using cross:
  • x86_64-unknown-linux-gnu
  • aarch64-unknown-linux-gnu
  • x86_64-pc-windows-gnu
  • x86_64-apple-darwin
  • aarch64-apple-darwin
  1. Removed OpenSSL from dependencies because it caused issues with compiling on aarch64 linux.
  2. Some docs cleanup on the requirements for compiling openssl.

@ogenev ogenev self-assigned this Nov 6, 2023
@ogenev ogenev added the flamingo Maintenance or downtime for the person on Flamingo rotation to tackle label Nov 6, 2023
@ogenev ogenev changed the title New make file Cross-compile Trin on a new release Jan 31, 2024
@ogenev ogenev marked this pull request as ready for review January 31, 2024 11:17
KolbyML
KolbyML approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: lets go. using native rust ssl is very nice too!

@KolbyML
Copy link
Member

KolbyML commented Jan 31, 2024

test config::checkpoints::test::test_fetch_latest_checkpoints has been running for over 60 seconds

This seems to be failing the test ci?

@ogenev
Copy link
Member Author

ogenev commented Jan 31, 2024

test config::checkpoints::test::test_fetch_latest_checkpoints has been running for over 60 seconds

This seems to be failing the test ci?

Yeah, it seems a flaky test

@njgheorghita
Copy link
Collaborator

@ogenev #1099 (comment)

@ogenev ogenev merged commit 534c4a1 into ethereum:master Feb 1, 2024
11 checks passed
@ogenev ogenev deleted the update-make-file branch February 1, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KolbyML KolbyML KolbyML approved these changes

@njgheorghita njgheorghita Awaiting requested review from njgheorghita

Assignees

@ogenev ogenev

Labels
flamingo Maintenance or downtime for the person on Flamingo rotation to tackle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogenev @KolbyML @njgheorghita