fix: address PR comments

ethereum · Dec 7, 2023 · b851560 · b851560
1 parent 28585ea
commit b851560
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/book/src/developers/contributing/build_instructions/windows.md b/book/src/developers/contributing/build_instructions/windows.md
@@ -9,6 +9,11 @@ If you don't already have Rust install it
 $ winget install Rustlang.Rustup
 ```
 
+Install clang/llvm as it is required to compile c-kzg
+```sh
+$ winget install LLVM.LLVM
+```
+
 Add Rust's msvc target
 ```sh
 $ rustup target add x86_64-pc-windows-msvc

diff --git a/portalnet/src/storage.rs b/portalnet/src/storage.rs
@@ -400,7 +400,7 @@ impl PortalStorage {
         // store content key w/o the 0x prefix
         let content_key = hex_encode(content_key).trim_start_matches("0x").to_string();
         if let Err(err) = self.db_insert(&content_id, &content_key, value) {
-            debug!("Error writing content ID {:?} to db: {:?}", content_id, err);
+            debug!("Error writing content ID {content_id:?} to db: {err:?}");
             return Err(err);
         } else {
             self.metrics.increase_entry_count();
@@ -804,6 +804,7 @@ pub mod test {
 
     use crate::utils::db::{configure_node_data_dir, setup_temp_dir};
     use ethportal_api::types::content_key::overlay::IdentityContentKey;
+    use ethportal_api::BlockHeaderKey;
 
     const CAPACITY_MB: u64 = 2;
 
@@ -869,7 +870,6 @@ pub mod test {
         let storage_config =
             PortalStorageConfig::new(CAPACITY_MB, temp_dir.path().to_path_buf(), node_id).unwrap();
         let mut storage = PortalStorage::new(storage_config, ProtocolId::History)?;
-        use ethportal_api::BlockHeaderKey;
         let content_key = HistoryContentKey::BlockHeaderWithProof(BlockHeaderKey::default());
         let value: Vec<u8> = "OGFWs179fWnqmjvHQFGHszXloc3Wzdb4".into();
         storage.store(&content_key, &value)?;

diff --git a/trin-state/Cargo.toml b/trin-state/Cargo.toml
@@ -16,7 +16,6 @@ async-trait = "0.1.53"
 discv5 = { git = "https://github.com/njgheorghita/discv5.git", rev = "700bdb97afd87016222e902f844bb95eb0d78d99", features = ["serde"] }
 ethereum-types = "0.14.1"
 ethportal-api = { path = "../ethportal-api" }
-eth_trie = "0.4.0"
 parking_lot = "0.11.2"
 portalnet = { path = "../portalnet" }
 tracing = "0.1.36"