Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistently use 0x prefixes in RLP tests #587

Merged
merged 3 commits into from
Feb 20, 2019

Conversation

AlexKnauth
Copy link
Contributor

@AlexKnauth AlexKnauth commented Feb 14, 2019

This finishes what #557 started, to use 0x prefixes consistently in rlptest.json, invalidRLPTest.json, and RandomRLPTests/example.json.

This also updates the documentation in rlp_tests.rst to describe the 0x and # prefixes.

This finishes what ethereum#557 started, to use 0x prefixes consistently in rlptest.json, invalidRLPTest.json, and RandomRLPTests/example.json.

This also updates the documentation in rlp_tests.rst describe the `0x` and `#` prefixes.
@winsvega
Copy link
Collaborator

have you checked that testeth is working with this change ?

@AlexKnauth
Copy link
Contributor Author

I haven't gotten testeth working on my computer yet, so I don't know.

@holgerd77
Copy link
Contributor

@AlexKnauth Testeth now has it's own up-to-date docker image, so it should be (in theory, please report if otherwise) relatively easy to test.

@AlexKnauth
Copy link
Contributor Author

@holgerd77 Thank you. I've tried running the command

docker run \
    -v /Users/Alex/Documents/GitHub/ethereum/tests:/foobar \
    ethereum/testeth:nightly \
    -t RLPTests \
    -- --testpath /foobar

However, it seems like testeth can't find RLPTests. It fails with the error

Test setup error: no test cases matching filter or all test cases were disabled

@winsvega
Copy link
Collaborator

This is boost error. Make sure the path to test repo is correct. What is /foobar ?

@AlexKnauth
Copy link
Contributor Author

The directory within the Docker container. The -v .../ethereum/tests:/foobar option to docker run should put the contents of ethereum/tests on my filesystem into /foobar inside the Docker container.

@winsvega
Copy link
Collaborator

try out testeth -t RlpTests

@AlexKnauth
Copy link
Contributor Author

Oh, with RlpTests instead of RLPTests it's working!

It's case sensitive, with a different case convention than the folder names. Thank you.

The command:

docker run \
    --mount type=bind,source="/Users/Alex/Documents/GitHub/ethereum/tests",target=/foobar \
    ethereum/testeth:nightly \
    -t RlpTests \
    -- --testpath /foobar

Succeeds on both the develop branch and my rlp-0x branch.

@winsvega
Copy link
Collaborator

Ready to merge?

@AlexKnauth
Copy link
Contributor Author

I think it's ready on my end.

@winsvega winsvega merged commit 0494078 into ethereum:develop Feb 20, 2019
@AlexKnauth AlexKnauth deleted the rlp-0x branch February 20, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants