Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constfix #582

Merged
merged 8 commits into from
Jan 24, 2019
Merged

Constfix #582

merged 8 commits into from
Jan 24, 2019

Conversation

winsvega
Copy link
Collaborator

No description provided.

@holiman
Copy link
Contributor

holiman commented Jan 22, 2019

These tests seem to work for geth. See https://github.com/ethereum/go-ethereum/pull/18486/files#diff-15ce625a7afa9c3d8ea9ffc9b74a654aR49 . The only failing tests (as far as StateTests are concerned are

	st.fails(`^stRevertTest/RevertPrecompiledTouch(_storage)?\.json/Byzantium/0`, "bug in test")
	st.fails(`^stRevertTest/RevertPrecompiledTouch(_storage)?\.json/Byzantium/3`, "bug in test")
	st.fails(`^stRevertTest/RevertPrecompiledTouch(_storage)?\.json/Constantinople/0`, "bug in test")
	st.fails(`^stRevertTest/RevertPrecompiledTouch(_storage)?\.json/Constantinople/3`, "bug in test")
	st.fails(`^stRevertTest/RevertPrecompiledTouch(_storage)?\.json/ConstantinopleFix/0`, "bug in test")
	st.fails(`^stRevertTest/RevertPrecompiledTouch(_storage)?\.json/ConstantinopleFix/3`, "bug in test")

And those are cases of precompiles being touched and reverted and such things, which is not a mainnet issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants