-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move creation tests to validation tests #1337
Conversation
The generated tests need to be moved too |
b02a11f
to
904583e
Compare
Removed Blockchain tests without fillers. |
@hugo-dc Please rebase. |
904583e
to
a503e97
Compare
Rebased |
a503e97
to
046c884
Compare
|
Same about |
I just deleted those leftover files, @hugo-dc please check |
It looks good now.
Usually retesteth itself catches json files without fillers when running the tests (not filling), I was double checking by doing that but somehow it didn't reported these files. Another difference I see is that the BlockchainTest |
@winsvega This is ready to go from our side, please review. |
it should be 0x060000 in genesis now. it is a minor correction for the state tests to have 0 in the first block in its blockchain tests form the genesis value must be 60000 |
Previous tests validating EOF by creating using CREATE/CREATE2/CreateTransaction were moved to the EOF Validation test format, as it is no longer valid EOF creation using the previous legacy methods.