-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refill transient storage tests with updated specs on Cancun #1237
Conversation
All passed by evmone. |
do these tests use the updated opcodes as well ? |
Yes, the opcode change is what triggered this refill. |
Ah okey, are all the tests refilled? because 21 of them for some reason invoke a precompile (with address 0x0a), or is that by design? |
Yea, the tests need to be updated, and then refilled. |
idk what was the reason to use 0x0A as contract address in this test. I think we can change it to a different address. but lets see if it fails, the precompiles should not be redefined in pre section |
Dunno about other clients, but for geth, it doesn't matter if a precompile "has code", we will execute the precompile, not the code associated with the account. So it's not possible to redefine them in the |
That's the problem Besu ran into as well. We check registered precompiles before checking for code, so when the new precompile landed tests broke. |
No description provided.