Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refill transient storage tests with updated specs on Cancun #1237

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

winsvega
Copy link
Collaborator

No description provided.

@chfast
Copy link
Member

chfast commented Jun 29, 2023

All passed by evmone.

@Demuirgos
Copy link

do these tests use the updated opcodes as well ?

@shemnon
Copy link
Contributor

shemnon commented Jul 5, 2023

Yes, the opcode change is what triggered this refill.

@Demuirgos
Copy link

Yes, the opcode change is what triggered this refill.

Ah okey, are all the tests refilled? because 21 of them for some reason invoke a precompile (with address 0x0a), or is that by design?

@shemnon
Copy link
Contributor

shemnon commented Jul 6, 2023

Yea, the tests need to be updated, and then refilled. 0xA is now a precompile address so these tests should fail spectacularly once we get more clients implementing it.

@winsvega
Copy link
Collaborator Author

winsvega commented Jul 7, 2023

idk what was the reason to use 0x0A as contract address in this test. I think we can change it to a different address. but lets see if it fails, the precompiles should not be redefined in pre section

@holiman
Copy link
Contributor

holiman commented Jul 11, 2023

I think we can change it to a different address. but lets see if it fails, the precompiles should not be redefined in pre section

Dunno about other clients, but for geth, it doesn't matter if a precompile "has code", we will execute the precompile, not the code associated with the account. So it's not possible to redefine them in the pre.

@shemnon
Copy link
Contributor

shemnon commented Jul 11, 2023

That's the problem Besu ran into as well. We check registered precompiles before checking for code, so when the new precompile landed tests broke.

@winsvega winsvega merged commit ee3fa4c into develop Jul 13, 2023
@winsvega winsvega deleted the refill1153 branch July 13, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants