fix: sha3 package build error #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
response to build error from indirect sha3 package dependency
wackerow
changed the title
✅ Deploy Preview for dapper-rolypoly-9814ad ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wackerow
changed the title
|
I've built this into my changes in #721 but we can merge it in isolation to |
CarlBeek
approved these changes
Jan 24, 2025
README.md
Outdated
| @@ -26,7 +26,7 @@ The Infura Project ID will enable the network status progress bar showing the ba | |||
| REACT_APP_INFURA_PROJECT_ID=your-infura-project-id-here | |||
| ``` | |||
|
|
|||
| Note: The Portis wallet option is not available when running locally | |||
| Note: The Portis wallet option is currently not available | |||
There was a problem hiding this comment.
I don't think we even really need to have this here, I think we can just nuke Portis & note something about removing it in a changelog & commit history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sha3indirect dependency tracing to@web3-react/portis-connectorpackage no longer compatible, causing builds to break during dependency installation. removing package while still on older version of node to restore buildsAlso patches a linting error from recent Nethermind page change, removing unused imports.