Support --chain goerli
#276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add Goerli, which is an alias of Prater 2. Remove Kintsugi
CarlBeek
approved these changes
Jul 29, 2022
staking_deposit/settings.py
Outdated
| # Merge Testnet (spec v1.1.9) | ||
| KilnSetting = BaseChainSetting(NETWORK_NAME=KILN, GENESIS_FORK_VERSION=bytes.fromhex('70000069')) | ||
|
|
||
|
|
||
| ALL_CHAINS: Dict[str, BaseChainSetting] = { | ||
| MAINNET: MainnetSetting, | ||
| ROPSTEN: RopstenSetting, | ||
| GOERLI: GoerliSetting, | ||
| PRATER: PraterSetting, |
There was a problem hiding this comment.
Instead of defining PraterSetting separately, why don't we only define a GoerliSetting and just define PRATER: GoerliSetting, in this map? This way we clean up the duplicate settings & variables in lines 23-26 and only have to manage one BaseChainSetting for both.
Merged
everhusk
pushed a commit
to earthwallet/earth-wallet-cli
that referenced
this pull request
Aug 3, 2023
Support `--chain goerli`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://blog.ethereum.org/2022/07/27/goerli-prater-merge-announcement/
In this PR:
goerli is not a valid language option#272)Discussion: I kept Prater for backward compatibility, but maybe we can just remove it now...? @CarlBeek what do you think?