-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version bumps packages #249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
really appreciate making the hash updates 🙏
Tested the binaries on both Win10 and Win11 machines with the latest security patches and this seems to have solved Windows' misplaced concerns about it being a trojan... Thanks to @SomerEsat for the bug report & helping with the testing. I updated the branch protection rules for dev for the new |
Version bumps packages
Rationale
Minimum Python version
I wanted to keep support for Python 3.7 as it will receive security patches until 2023-06, but officially it stopped receiving support in 2020-06 and so many packages needed >=3.8 in order to be updated. As such, I migrated minimum version requirements to Python 3.8.
CLI Binaries Python Version
We used to build the binaries with 3.7 to ensure maximum support, but I discovered this is not actually the case. As PyInstaller bundles the Python interpreter with the package, we do not need to use an older version of python. As such, I upgraded the builds to run off of 3.10.
Testing Python Versions
In accordance with the above changes, CI testing now happens for Python 3.8 & 3.10