Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARMv7 hashes in requirements.txt #184

Merged
merged 2 commits into from
Mar 30, 2021
Merged

ARMv7 hashes in requirements.txt #184

merged 2 commits into from
Mar 30, 2021

Conversation

ceroma
Copy link
Contributor

@ceroma ceroma commented Feb 22, 2021

Raspberry Pis are convenient devices for offline keystore generation.
However, deposit-cli currently doesn't build successfully on Pis since some dependencies have ARMv7-specific binaries that aren't listed in requirements.txt.

This commit adds the appropriate hashes to the list:
cytoolz:
cytoolz-0.10.1-cp37-cp37m-linux_armv7l.whl 5161bef77f7b69bea64b4e052d0da17845e6adae6d09f91cc7e5acfc5cb2c5c4

lru-dict:
lru_dict-1.1.6-cp37-cp37m-linux_armv7l.whl 288d8794e9376fe31d27abc3531d395675b2a910781f26034d5ef79f0ba9cecc

pycryptodome:
pycryptodome-3.9.8-cp37-cp37m-linux_armv7l.whl be7553b8bea117892f83f52ebfe96929340cacae07f3f6a820291e42168dff62

toolz:
toolz-0.10.0-py3-none-any.whl c43f7cffb32a3c8e3fb51192cae4dcdbf0a6fee4d07142ca2e443d2bd9f89400

typed-ast:
typed_ast-1.4.1-cp37-cp37m-linux_armv7l.whl 3791f73e5d75aa9a95274679ab4821bd9d16de623c4ecf4900a77a29864ee144

--

Tested on a Raspberry Pi 3 Model B Rev 1.2 running Raspbian Buster.
Tests pass correctly.
Ran a few examples of new-mnemonic and existing-mnemonic.
Compared resulting deposit_data-<timestamp>.json with the ones generated on a Mac for the same set of inputs and they matched.

Adds hashes for ARMv7 binaries of certain requirements that need so:
[cytoolz](https://www.piwheels.org/project/cytoolz/):
cytoolz-0.10.1-cp37-cp37m-linux_armv7l.whl 5161bef77f7b69bea64b4e052d0da17845e6adae6d09f91cc7e5acfc5cb2c5c4

[lru-dict](https://www.piwheels.org/project/lru-dict/):
lru_dict-1.1.6-cp37-cp37m-linux_armv7l.whl 288d8794e9376fe31d27abc3531d395675b2a910781f26034d5ef79f0ba9cecc

[pycryptodome](https://www.piwheels.org/project/pycryptodome/):
pycryptodome-3.9.8-cp37-cp37m-linux_armv7l.whl be7553b8bea117892f83f52ebfe96929340cacae07f3f6a820291e42168dff62

[toolz](https://www.piwheels.org/project/toolz/):
toolz-0.10.0-py3-none-any.whl c43f7cffb32a3c8e3fb51192cae4dcdbf0a6fee4d07142ca2e443d2bd9f89400

[typed-ast](https://www.piwheels.org/project/typed-ast/):
typed_ast-1.4.1-cp37-cp37m-linux_armv7l.whl 3791f73e5d75aa9a95274679ab4821bd9d16de623c4ecf4900a77a29864ee144

--

Tested on a Raspberry Pi 3 Model B Rev 1.2 running Raspbian Buster.
Tests pass correctly.
Ran a few examples of `new-mnemonic` and `existing-mnemonic`.
Compared resulting `deposit_data-<timestamp>.json` with the ones generated on a Mac for the same set of inputs and they matched.
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ceroma Thank you so much for making this PR! 👍

I verified the hashes against the package json files.

requirements.txt Outdated Show resolved Hide resolved
@hwwhww hwwhww merged commit d27f7e2 into ethereum:dev Mar 30, 2021
@ceroma ceroma deleted the armv7 branch March 30, 2021 16:29
@CarlBeek CarlBeek mentioned this pull request Apr 2, 2021
1 task
everhusk pushed a commit to earthwallet/earth-wallet-cli that referenced this pull request Aug 3, 2023
ARMv7 hashes in requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants