-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verification with Standard JSON Input #980
Conversation
Refactor SearchSelect's onChange function and its types to be able to reuse SearchSelect consistently. Initial naive implementation of using solcJson as input in session
To allow multipart/form-data requests
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## staging #980 +/- ##
===========================================
- Coverage 77.85% 74.82% -3.03%
===========================================
Files 29 36 +7
Lines 1368 2038 +670
Branches 252 390 +138
===========================================
+ Hits 1065 1525 +460
- Misses 177 307 +130
- Partials 126 206 +80
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small things, great job! 🚀
Question from an interested outsider: What would happen if someone used this interface to attempt to verify a Yul contract, setting |
@haltman-at Thanks for pointing this out! I tried with the examples in the Solidity docs Yul page. The compiler compiles just fine but since the compiler output JSON does not have So we should check if the language is "Solidity" |
Closes #945
CustomSelectSearch
and instead use theSelectSearch
from the library itself with the correct types. CustomSelectSearch was there for a type workaround of theonChange
prop: first removes the type, then adds the custom type. With the correct type from the library itself, there's no need for that.fuzzySearch
to its own module as it's reused.ChainSelect
GithubBranchSelect
SolcJsonInput.tsx
with the out-of-the-boxSelectSearch
.View in Huly HI-715