Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .sol extension in repositoryV2 #1648

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Remove .sol extension in repositoryV2 #1648

merged 1 commit into from
Sep 25, 2024

Conversation

kuzdogan
Copy link
Member

Following the discussion: https://discord.com/channels/1160912737539473410/1160912738374127689/1287445616972140565

I don't see any downsides of this. If you think of something lmk.

marcocastignoli
marcocastignoli approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@marcocastignoli marcocastignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't see any downsides for this.

@kuzdogan kuzdogan mentioned this pull request Sep 23, 2024
Closed
4 tasks
@kuzdogan
Copy link
Member Author

Leaving mergin this to you @manuelwedler

@manuelwedler manuelwedler mentioned this pull request Sep 25, 2024
Merged
@manuelwedler manuelwedler merged commit 6df1374 into staging Sep 25, 2024
6 checks passed
@manuelwedler manuelwedler deleted the remove-sol-ext-repov2 branch September 25, 2024 13:42
@sealer3 sealer3 mentioned this pull request Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcocastignoli marcocastignoli marcocastignoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Sourcify Public
Status: COMPLETED
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuzdogan @marcocastignoli @manuelwedler