Resolve ENS addresses upon submission #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corydickson
commented
Mar 31, 2020
| files: string[] | ||
| ) : Promise<string[]> { | ||
|
|
||
| if (address) { | ||
| if (isENS) { |
There was a problem hiding this comment.
Another way this could be achieved is keeping the assumption the input is not sanitized and match domains here, not sure if we should be accepting subdomains...
|
After doing some digging not sure if this will work for all of the supported chainIds, is it acceptable to limit it to mainnet, rinkeby, ropsten |
|
We can add a corresponding prompt for the user as well |
|
@corydickson that's definitely a good start. Not sure if the prompt is needed as we already get the network (chain) so we can just check in isEns is one of the listed networks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #90
The approach laid out here uses the existing submission endpoint to resolve an ENS address. I went this way to avoid bringing in another web3 instance into the project, despite some of the comments in the issue indicating the ability to provide some tooltip or notification of bad user input
Let me know if that would be preferred and we can also sanitize for regular bytecode addresses
View in Huly HI-879