Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Base mainnet (8453) #1112

Merged
merged 4 commits into from
Jul 16, 2023
Merged

Add Base mainnet (8453) #1112

merged 4 commits into from
Jul 16, 2023

Conversation

mdehoog
Copy link
Contributor

@mdehoog mdehoog commented Jul 14, 2023

Add New Chain 8453

Checklist

  • The branch is named as add-chain-<chainId>.
  • I haven't modified the chains.json file directly.
  • In sourcify-chains.ts file
    • I've set supported: true.
    • I've set monitored: false.
    • I haven't added an rpc field but the one in chains.json is used (if not, please explain why).
  • I've added a test in chain-tests.js file.
  • test-new-chain test in Circle CI is passing.

View in Huly HI-642

@mdehoog mdehoog changed the title Add Base mainnet Add Base mainnet (8453) Jul 14, 2023
src/sourcify-chains.ts Outdated Show resolved Hide resolved
@kuzdogan
Copy link
Member

Updated chains.json. Can you please remove the rpc and rebase/merge from staging?

@mdehoog
Copy link
Contributor Author

mdehoog commented Jul 14, 2023

Any suggestions on getting tests to pass?

Error: No RPC provider was given for this chain with id 1 and name Ethereum Mainnet

Locally this was resolved by copying .env.dev to .env but don't want to commit that.

@kuzdogan
Copy link
Member

I don't know where this has come from. I'll have a look

@mdehoog
Copy link
Contributor Author

mdehoog commented Jul 14, 2023

@kuzdogan this is caused by f4d68cf

@kuzdogan
Copy link
Member

kuzdogan commented Jul 16, 2023

This was unexpected because the tests were passing on our commits. On external PRs there are no env vars and the rpc of those chains with env var rpcs end up as an empty array, hence the error.

Can you please rebase one last time? Just merged myself

@kuzdogan kuzdogan marked this pull request as ready for review July 16, 2023 15:08
@kuzdogan kuzdogan merged commit 17a3982 into ethereum:staging Jul 16, 2023
@mdehoog mdehoog deleted the add-chain-8453 branch July 22, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants