Blockscout scraping and use c8 instead of nyc
#1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## staging #1092 +/- ##
===========================================
+ Coverage 78.88% 85.60% +6.72%
===========================================
Files 56 67 +11
Lines 1539 8002 +6463
Branches 271 598 +327
===========================================
+ Hits 1214 6850 +5636
- Misses 189 1138 +949
+ Partials 136 14 -122
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kuzdogan
force-pushed
the
blockscout-scraping
branch
from
e5d8b4f
to
e792564
Compare
Since the new Blockscout uses client side rendering, we need a browser to scrape the page contents. Use puppeteer to scrape. Also update `txRegex` to be an array to support trying multiple regexes.
After adding `puppeteer` we started getting `cov_{id} is not defined`
errors.
This was caused by `nyc` which hasn't been updated in years.
It would make sense to move to a more up-to-date coverage library.
See istanbuljs/nyc#1327
kuzdogan
force-pushed
the
blockscout-scraping
branch
from
e792564
to
592ab8e
Compare
kuzdogan
changed the title
c8 instead of nyc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently noticed one of the tests started failing where we were scaping the transaction hash from the block explorer. This is because the chain's (Gnosis) Blockscout has been updated with the new Blockscout UI. This caused both the regex to not work anymore, as well as not being able to load the page contents with a fetch because the new UI is client-side rendered.
Update the scraping to try multiple regex'es, both the one for the old and the new UI.
Uses
puppeteerto load the page to be scraped. This required to install the puppeteer dependencies on the containers that are running Sourcify and CI containers running tests: https://app.circleci.com/pipelines/github/ethereum/sourcify/4300/workflows/49a22229-32c3-408a-8459-622ecd863762/jobs/23775Additionally we started getting
cov_{id} is not definederrros in tests: https://app.circleci.com/pipelines/github/ethereum/sourcify/4309/workflows/35ad9ef7-524e-43b1-8ae5-4cf8d0455c65/jobs/23803 This was caused by thenyclibrary which hasn't been updated for some time. Move toc8instead for coverage which is more up-to-date. See istanbuljs/nyc#1327View in Huly HI-547