Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kava Mainnet Chain (2222) #1087

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

0xRaghu
Copy link
Contributor

@0xRaghu 0xRaghu commented Jul 3, 2023

Add New Chain 2222

Checklist

  • The branch is named as add-chain-<chainId>.
  • I haven't modified the chains.json file directly.
  • In sourcify-chains.ts file
    • I've set supported: true.
    • I've set monitored: false.
    • I haven't added an rpc field but the one in chains.json is used (if not, please explain why).
  • I've added a test in chain-tests.js file.
  • test-new-chain test in Circle CI is passing.

View in Huly HI-660

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -7.88 ⚠️

Comparison is base (c3d9f10) 79.47% compared to head (9bbb319) 71.59%.

❗ Current head 9bbb319 differs from pull request most recent head fb163a8. Consider uploading reports for the commit fb163a8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1087      +/-   ##
===========================================
- Coverage    79.47%   71.59%   -7.88%     
===========================================
  Files           55       66      +11     
  Lines         1520     2394     +874     
  Branches       267      440     +173     
===========================================
+ Hits          1208     1714     +506     
- Misses         181      466     +285     
- Partials       131      214      +83     
Flag Coverage Δ
lib-sourcify 66.19% <ø> (?)
server 74.59% <50.00%> (-4.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ommon/SourcifyEventManager/SourcifyEventManager.ts 100.00% <ø> (ø)
src/sourcify-chains.ts 84.31% <ø> (ø)
src/server/server.ts 73.39% <42.85%> (-6.61%) ⬇️
src/common/errors/TooManyRequests.ts 50.00% <50.00%> (ø)
...rollers/verification/etherscan/etherscan.common.ts 19.04% <50.00%> (-56.76%) ⬇️
src/monitor/monitor.ts 85.15% <75.00%> (+1.56%) ⬆️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marcocastignoli marcocastignoli merged commit a210c1e into ethereum:staging Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants