Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rollux #1076

Merged
merged 7 commits into from
Jun 23, 2023
Merged

Add Rollux #1076

merged 7 commits into from
Jun 23, 2023

Conversation

fernando-syslabs
Copy link
Contributor

@fernando-syslabs fernando-syslabs commented Jun 23, 2023

Add New Chain 570

The PR includes Rollux Testnet and removes a duplicated entry for Syscoin Tanenbaum.

Checklist

  • The branch is named as add-chain-<chainId>.
  • I haven't modified the chains.json file directly.
  • In sourcify-chains.ts file
    • I've set supported: true.
    • I've set monitored: false.
    • I haven't added an rpc field but the one in chains.json is used (if not, please explain why).
  • I've added a test in chain-tests.js file.
  • test-new-chain test in Circle CI is passing.

View in Huly HI-664

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -7.61 ⚠️

Comparison is base (941886b) 79.59% compared to head (886fb35) 71.98%.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1076      +/-   ##
===========================================
- Coverage    79.59%   71.98%   -7.61%     
===========================================
  Files           55       64       +9     
  Lines         1519     2342     +823     
  Branches       267      434     +167     
===========================================
+ Hits          1209     1686     +477     
- Misses         179      447     +268     
- Partials       131      209      +78     
Flag Coverage Δ
lib-sourcify 66.34% <ø> (?)
server 75.04% <ø> (-4.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourcify-chains.ts 84.31% <ø> (ø)

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kuzdogan
Copy link
Member

Normally these should be two separate PRs but I've verified it works manually.

@kuzdogan kuzdogan merged commit 410b300 into ethereum:staging Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants