Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zora chain mainnet 7777777 #1064

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Conversation

iainnash
Copy link
Contributor

@iainnash iainnash commented Jun 16, 2023

Add New Chain 7777777

Thanks for your pull request to add a new support in Sourcify.

If you haven't done so, please follow the instructions on how to request chain support in docs.

Please check the following items before submitting your pull request.

Checklist

  • The branch is named as add-chain-<chainId>.
  • I haven't modified the chains.json file directly. – pulled it in using the script
  • In sourcify-chains.ts file
    • I've set supported: true.
    • I've set monitored: false.
    • I haven't added an rpc field but the one in chains.json is used (if not, please explain why).
  • I've added a test in chain-tests.js file.
  • test-new-chain test in Circle CI is passing.

View in Huly HI-668

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -7.84 ⚠️

Comparison is base (0a21ecc) 77.65% compared to head (52ef66b) 69.82%.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1064      +/-   ##
===========================================
- Coverage    77.65%   69.82%   -7.84%     
===========================================
  Files           31       40       +9     
  Lines         1450     2270     +820     
  Branches       266      432     +166     
===========================================
+ Hits          1126     1585     +459     
- Misses         188      468     +280     
- Partials       136      217      +81     
Flag Coverage Δ
lib-sourcify 66.70% <ø> (?)
server 71.58% <ø> (-6.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourcify-chains.ts 84.94% <ø> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kuzdogan
Copy link
Member

I see you're modifying the chains.json as required in the second TO-DO check. Please don't modify the file.

We've updated the chains.json. Please merge from staging or rebase

@iainnash
Copy link
Contributor Author

Rebased and pushed.

I read this incorrectly as running the script to import chains vs manually adding a chain. That's on me.

@iainnash
Copy link
Contributor Author

Found a build issue and created an upstream PR to fix it: #1070

@kuzdogan
Copy link
Member

Can you please rebase again? The edits look good now 👍 Will merge once tests pass

@kuzdogan kuzdogan merged commit dfe1782 into ethereum:staging Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants