Add New Chain 6119 (SK) #1063
Merged
Add New Chain 6119 (SK) #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## staging #1063 +/- ##
===========================================
- Coverage 77.65% 70.04% -7.62%
===========================================
Files 31 40 +9
Lines 1450 2270 +820
Branches 266 432 +166
===========================================
+ Hits 1126 1590 +464
- Misses 188 465 +277
- Partials 136 215 +79
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Hello It seems you didn't add a test. Can you please add a chain test? |
|
Added the test and its failing but this is the right data |
|
The file you're adding is not the metadata but the hardhat artifact. Also please remove the changes the the |
For some reason, exit 1 command was not killing the container as expected. Instead first gracefully stop ipfs daemon and then terminate the conatiner with `pkill entrypoint.sh`. This will cause a restart as `restart: always` is set.
|
Rebased and tests passing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add New Chain
Thanks for your pull request to add a new support in Sourcify.
If you haven't done so, please follow the instructions on how to request chain support in docs.
Please check the following items before submitting your pull request.
Checklist
add-chain-<chainId>.supported: true.monitored: false.rpcfield but the one in chains.json is used (if not, please explain why).test-new-chaintest in Circle CI is passing.View in Huly HI-651