Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elysium Mainnet chain #1055

Merged
merged 6 commits into from
Jun 10, 2023
Merged

Conversation

aqeelVaival
Copy link
Contributor

@aqeelVaival aqeelVaival commented Jun 8, 2023

Add New Chain 1339

Thanks for your pull request to add a new support in Sourcify.

If you haven't done so, please follow the instructions on how to request chain support in docs.

Please check the following items before submitting your pull request.

Checklist

  • [ ✅ ] The branch is named as add-chain-1339.
  • [ ✅ ] I haven't modified the chains.json file directly.
  • [ ✅ ] In sourcify-chains.ts file
    • [✅ ] I've set supported: true.
    • [ ✅ ] I've set monitored: false.
    • [✅ ] I haven't added an rpc field but the one in chains.json is used (if not, please explain why).
  • [ ✅ ] I've added a test in chain-tests.js file.
  • [ ✅ ] test-new-chain test in Circle CI is passing.

View in Huly HI-676

@kuzdogan
Copy link
Member

kuzdogan commented Jun 8, 2023

I believe you have deployed the 1_Storage contract at 0x20563837F7423465699D7675BCB82f886a761c25 as I can see in the test but I also see you add an additional large LERC20-role.sol. Can you remove the added .sol file?

@aqeelVaival
Copy link
Contributor Author

@kuzdogan why test cases have being failing?

@aqeelVaival
Copy link
Contributor Author

image
@kuzdogan

@aqeelVaival
Copy link
Contributor Author

@kuzdogan please let me know once you are available, kindly help to get it merge

@kuzdogan
Copy link
Member

kuzdogan commented Jun 9, 2023

Apparently lerna pushed a new version v7 which removes the bootstrap command we were using to install our submodules. Now the CI flows install the specific version before calling.

Can you please rebase or merge from staging?

@kuzdogan kuzdogan merged commit d449b7a into ethereum:staging Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants