-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for chain verification tests #1031
Conversation
Thanks to the metadata variations, we are apparently able to get a "perfect" match for the Bobascan single contract test case. Change the expected status to "perfect" Also rename OriginalMetadata to PerfectMetadata as it is more descriptive
The chains seems to be inactive as well as the blockexplorer is stuck at 5 months ago: https://blockscout.com/poa/sokol/
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## staging #1031 +/- ##
===========================================
- Coverage 77.65% 73.52% -4.14%
===========================================
Files 31 40 +9
Lines 1450 2270 +820
Branches 266 431 +165
===========================================
+ Hits 1126 1669 +543
- Misses 188 372 +184
- Partials 136 229 +93
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
"was that problem with us too - while i tried to run a verification for dogechain?" i meant was that the reason for being it failed? thankie though! |
@oliviachef If you mean why your tests are not working, it is not related to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, lets remember to update the docs.
do we want to merge this PR after updating the docs or later? I'm asking this because someone willing to add chain support will push on staging reading the docs as they are now. So I'll merge the PR after updating the docs.
Yes right, let's merge after we update the docs. It's already a TODO in #970 |
Updated both Merging. Not squashed as each commit is meaningful by itself. |
okie maybe i misunderstood because of the "title"; sorry! |
This removes the deprecated, stale, and not-working chains from the tests as well as turns off support for them.
Additionally turns off monitoring support for Boba Mainnet
Removes immutable tests as we no longer need to check immutables separately, thanks to
immutableReferences
.Changes
tryToFindOriginalMetadata
naming to more explicittryToFindPerfectMetadata
Fix Bobascan test contract as now it is verified "perfect"ly thanks to the
tryToFindPerfectMetadta
.Add a double check if all the
supported: true
chains have a verification test added.View in Huly HI-554