Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for chain verification tests #1031

Merged
merged 22 commits into from
May 15, 2023
Merged

Fix for chain verification tests #1031

merged 22 commits into from
May 15, 2023

Conversation

kuzdogan
Copy link
Member

@kuzdogan kuzdogan commented May 12, 2023

This removes the deprecated, stale, and not-working chains from the tests as well as turns off support for them.

Additionally turns off monitoring support for Boba Mainnet

Removes immutable tests as we no longer need to check immutables separately, thanks to immutableReferences.

Changes tryToFindOriginalMetadata naming to more explicit tryToFindPerfectMetadata

Fix Bobascan test contract as now it is verified "perfect"ly thanks to the tryToFindPerfectMetadta.

Add a double check if all the supported: true chains have a verification test added.

View in Huly HI-554

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -4.14 ⚠️

Comparison is base (4861f46) 77.65% compared to head (c4c01e5) 73.52%.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1031      +/-   ##
===========================================
- Coverage    77.65%   73.52%   -4.14%     
===========================================
  Files           31       40       +9     
  Lines         1450     2270     +820     
  Branches       266      431     +165     
===========================================
+ Hits          1126     1669     +543     
- Misses         188      372     +184     
- Partials       136      229      +93     
Flag Coverage Δ
lib-sourcify 66.82% <ø> (?)
server 77.31% <ø> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourcify-chains.ts 84.94% <ø> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oliviachef
Copy link
Contributor

oliviachef commented May 12, 2023

"was that problem with us too - while i tried to run a verification for dogechain?" i meant was that the reason for being it failed? thankie though!

@kuzdogan
Copy link
Member Author

kuzdogan commented May 15, 2023

@oliviachef If you mean why your tests are not working, it is not related to this PR

Copy link
Member

@marcocastignoli marcocastignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets remember to update the docs.

do we want to merge this PR after updating the docs or later? I'm asking this because someone willing to add chain support will push on staging reading the docs as they are now. So I'll merge the PR after updating the docs.

@kuzdogan
Copy link
Member Author

Yes right, let's merge after we update the docs. It's already a TODO in #970

@kuzdogan
Copy link
Member Author

Updated both

Merging.

Not squashed as each commit is meaningful by itself.

@kuzdogan kuzdogan merged commit 81d2121 into staging May 15, 2023
@kuzdogan kuzdogan mentioned this pull request May 15, 2023
3 tasks
@oliviachef
Copy link
Contributor

@oliviachef If you mean why your tests are not working, it is not related to this PR

okie maybe i misunderstood because of the "title"; sorry!

@kuzdogan kuzdogan deleted the revisit-chain-tests branch December 19, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants