Throw before if compiled bytecode empty instead of later in creation bytecode #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcocastignoli
approved these changes
May 9, 2023
marcocastignoli
requested changes
May 9, 2023
As the function can be used as standalone, we should not remove the check from the function itself. Keep both this and throwing before trying to match.
marcocastignoli
approved these changes
May 9, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## staging #1022 +/- ##
===========================================
+ Coverage 73.79% 73.83% +0.03%
===========================================
Files 40 40
Lines 2267 2270 +3
Branches 429 431 +2
===========================================
+ Hits 1673 1676 +3
Misses 368 368
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at some other contracts and noticed that for abstract contracts the compiler returns empty bytecode.
I believe we should immediately throw if the user is trying to verify an abstract contract or for some reason, the compiler returns an empty bytecode.
View in Huly HI-718