Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle libraries with call protection #1000

Merged
merged 2 commits into from
May 3, 2023

Conversation

marcocastignoli
Copy link
Member

@marcocastignoli marcocastignoli commented Apr 26, 2023

See #996

View in Huly HI-710

@marcocastignoli
Copy link
Member Author

Since we discovered that this PR should handle all the cases, can we proceed? From my pov after writing a test we can merge, what do you think @kuzdogan?

@kuzdogan
Copy link
Member

Does this also cover the via-IR case? If so yes, let's add

  1. legacy compilation placeholder test case
    2.via-IR test case

and merge 👍

@marcocastignoli
Copy link
Member Author

Does this also cover the via-IR case? If so yes, let's add

I suppose the actual function replaceImmutableReferences already does this.

* legacy compilation placeholder test case
* via-IR test case
@marcocastignoli marcocastignoli marked this pull request as ready for review April 28, 2023 08:31
@marcocastignoli
Copy link
Member Author

I added the tests

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -3.82 ⚠️

Comparison is base (3028f63) 77.67% compared to head (4cc1519) 73.86%.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1000      +/-   ##
===========================================
- Coverage    77.67%   73.86%   -3.82%     
===========================================
  Files           29       38       +9     
  Lines         1375     2154     +779     
  Branches       254      408     +154     
===========================================
+ Hits          1068     1591     +523     
- Misses         178      347     +169     
- Partials       129      216      +87     
Flag Coverage Δ
lib-sourcify 67.13% <ø> (?)
server 77.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kuzdogan kuzdogan merged commit b84e466 into staging May 3, 2023
@kuzdogan kuzdogan deleted the handle-libraries-with-call-protection branch May 10, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants