-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Case-insensitive address queries #983
Comments
Thanks a lot for the report! @marcocastignoli wasn't it already resolved with this? #588 |
It used to work, I'll take a look at it. Thanks for the report |
* removing a useless setting in h5ai config * now formatting the address redirects to the `location /` that runs `try_files` successfuly
I'm not an expert regarding nginx configuration but I tried to follow the logic and it seems like I added a useless location that I removed in this PR sourcifyeth/h5ai-nginx#1 Can someone with more experience than me regarding nginx check it? |
* fix address checksum in repository
Locally on my machine it works... repo.staging.sourcify.dev still has the same probllem |
Leaving this aside for now as we couldn't tackle the problem successfully... The problem currently is that the h5ai-nginx config does not match the |
Currently the repo expects Mixed-case checksum Addresses on the queries, so if we use addresses with other cases it does not find the resource.
E.g: https://repo.sourcify.dev/contracts/full_match/100/0xC4c622862a8F548997699bE24EA4bc504e5cA865/metadata.json works https://repo.sourcify.dev/contracts/full_match/100/0xc4c622862a8f548997699be24ea4bc504e5ca865/metadata.json gives a 404
The dev experience could be improved by making the query work with addresses in any kind of case. As it stands, it's often necessary to add boilerplate to convert addresses to checksum mixed-casing in the code.
View in Huly HI-398
The text was updated successfully, but these errors were encountered: