#1071 prevent overriding already verified contract

* fix missing check for address/chainId
ethereum · Jun 21, 2023 · 7d8603f · 7d8603f
1 parent addbde0
commit 7d8603f
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/src/server/controllers/verification/verification.common.ts b/src/server/controllers/verification/verification.common.ts
@@ -299,16 +299,19 @@ export const verifyContractsInSession = async (
   for (const id in contractWrappers) {
     const contractWrapper = contractWrappers[id];
 
-    const found = repositoryService.checkByChainAndAddress(
-      contractWrapper.address as string,
-      contractWrapper.chainId as string
-    );
+    // Check if contract is already verified
+    if (Boolean(contractWrapper.address) && Boolean(contractWrapper.chainId)) {
+      const found = repositoryService.checkByChainAndAddress(
+        contractWrapper.address as string,
+        contractWrapper.chainId as string
+      );
 
-    if (found.length) {
-      contractWrapper.status = found[0].status || "error";
-      contractWrapper.statusMessage = found[0].message;
-      contractWrapper.storageTimestamp = found[0].storageTimestamp;
-      continue;
+      if (found.length) {
+        contractWrapper.status = found[0].status || "error";
+        contractWrapper.statusMessage = found[0].message;
+        contractWrapper.storageTimestamp = found[0].storageTimestamp;
+        continue;
+      }
     }
 
     await checkAndFetchMissing(contractWrapper.contract);